Remove MeshElementGroup deprecations #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This enables EDIT: Well that clearly doesn't work.. it just complains about all the other files. I'll remove that commit. |
alexfikl
force-pushed
the
remove-deprecated-element-groups
branch
from
4c03df5
to
982194b
Compare
|
I'm all in favor (also of getting the isort done). |
Got it! This still needs a bit of work apparently, so I'll ping you when it's done. |
alexfikl
force-pushed
the
remove-deprecated-element-groups
branch
2 times, most recently
from
25b861a
to
bd17454
Compare
alexfikl
force-pushed
the
remove-deprecated-element-groups
branch
from
bd17454
to
9916d68
Compare
alexfikl
commented
Mar 5, 2024
alexfikl
commented
Mar 5, 2024
inducer
reviewed
Mar 5, 2024
Removes: * BTAG_PARTITION.part_nr * MeshElementGroup.element_nr_base and node_nr_base * MeshElementGroup.copy * NodalAdjacency.copy * FacialAdjacencyGroup.copy
alexfikl
force-pushed
the
remove-deprecated-element-groups
branch
from
9916d68
to
65ef869
Compare
|
@inducer Re-added the missing note, so this should be ok now! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these seem to be at least a year overdue and a quick grep showed that nothing is using them anymore (in
mainat least).Inspired by #395.
Fixes #224.